Fix query tab data grid lag with large result sets#28
Merged
Conversation
InMemoryRowProvider was recreated on every SwiftUI body evaluation, causing O(n) heap allocations (e.g. 200k TableRowData objects per render). Client-side sorting also ran O(n log n) on every render when active. - Refactor InMemoryRowProvider to store QueryResultRow directly and create TableRowData lazily via a cache dictionary (~30 visible rows) - Add SortedRowsCache in MainEditorContentView keyed by tab ID, sort params, and resultVersion to avoid redundant sorting - Fix status bar showing pagination range (1-1000) for query tabs; now shows formatted total row count instead
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 46e6cd78a0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Increment resultVersion in switchDatabase, OpenTableTabSmart, and row paste operations so the sort cache doesn't return stale rows.
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
InMemoryRowProviderto lazily materializeTableRowDataon demand via a cache dictionary, eliminating O(n) heap allocations (e.g. 200k objects) on every SwiftUI body evaluationSortedRowsCacheinMainEditorContentViewkeyed by tab ID, sort params, andresultVersionto avoid redundant O(n log n) sorting on every render1-1000 of X rows) for query tabs — now shows formatted total row count (e.g.200,000 rows)Test plan
SELECT id, email, updated_at FROM users(200k rows) — scrolling, clicking rows, and switching tabs should be smooth200,000 rowsfor query tabs,1-1000 of 200,000 rowsfor table tabsxcodebuildswiftlint lint --strict